[Issue #4703] Add the pod name when we use podman ps -p

[NevilleC]

The pod name does not appear when doing podman ps -p.
It is missing as the documentation says:
-p, --pod Print the ID and name of the pod the containers are associated with

When we create a container, the pod name will be added in the ps output.

On master:

[x libpod]$ sudo bin/podman pod ps
POD ID         NAME                 STATUS    CREATED          # OF CONTAINERS   INFRA ID
01ede9c31b4d   inspiring_driscoll   Created   20 seconds ago   1                 04e03f9f9d55
[x libpod]$ sudo bin/podman ps -ap
CONTAINER ID  IMAGE                                 COMMAND  CREATED         STATUS   PORTS  NAMES                      POD
04e03f9f9d55  k8s.gcr.io/pause:3.1                           20 seconds ago  Created         01ede9c31b4d-infra         01ede9c31b4d

We cannot see the pod name in the second command.

On the feature branch:

[x libpod]$ sudo bin/podman pod ps
POD ID         NAME                 STATUS    CREATED         # OF CONTAINERS   INFRA ID
01ede9c31b4d   inspiring_driscoll   Created   5 seconds ago   1                 04e03f9f9d55
[x libpod]$ sudo bin/podman ps -ap
CONTAINER ID  IMAGE                                 COMMAND  CREATED         STATUS   PORTS  NAMES                      POD           POD NAME
04e03f9f9d55  k8s.gcr.io/pause:3.1                           16 seconds ago  Created         01ede9c31b4d-infra         01ede9c31b4d  inspiring_driscoll

The pod name does appear.

Closes #4703

Signed-off-by: NevilleC [email protected]

[openshift-ci-robot]

Hi @NevilleC. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mheon]

/ok-to-test

[mheon]

That sounds like the right thing to do in this case.

…

On Wed, Dec 25, 2019, 08:22 NevilleC ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In libpod/container.go <#4748 (comment)>: > @@ -227,6 +227,8 @@ type ContainerConfig struct { Name string `json:"name"` // Full ID of the pood the container belongs to Pod string `json:"pod,omitempty"` + // Name of the pod the container belongs to + PodName string `json:"podName,omitempty"` I could fix the tests in the CI by ensuring that the pod lookup is done if, and only if, the user has requested the pod details. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#4748>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB3AOCALIUDVJMPEIM3U7F3Q2NNBLANCNFSM4J7BMBBQ> .

[mheon]

[+1164s] [Fail] Podman ps [It] podman --pod with a non-empty pod name

Ahhh, it's Varlink. You didn't pipe it through the Varlink adapter code - BatchContainerOp() in pkg/adapter/containers_remote.go would also need to be patched.

@baude Given the state of Varlink right now, I'd almost rather we not do that and SkipIfRemote() the test. Thoughts?

[mheon]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, NevilleC

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

Looks like podman remote tests are failing?

[NevilleC]

@rhatdan Yes, I was waiting for an answer to see if I should pipe it through the Varlink adapter code or use the SkipIfRemote(), as suggested by @mheon #4748 (comment).

I used the SkipIfRemote() as it seems it would be the way to go for the moment after reading mheon's comment.

The CI should pass now.

[rhatdan]

LGTM
@mheon PTAL

[mheon]

LGTM

…

On Sat, Dec 28, 2019, 06:35 Daniel J Walsh ***@***.***> wrote: LGTM @mheon <https://github.com/mheon> PTAL — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4748>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB3AOCHSHMJGTCVKBV4ZXN3Q242XXANCNFSM4J7BMBBQ> .

[rhatdan]

/lgtm
Thanks @NevilleC