Bump Buildah to v1.12.0

[TomSweeneyRedHat]

Bump Buildah to v1.12.0.

Gets ADD with a url fix

Signed-off-by: TomSweeneyRedHat [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [TomSweeneyRedHat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TomSweeneyRedHat]

@mheon @rhatdan PTAL

[TomSweeneyRedHat]

@edsantiago fyi

[mheon]

LGTM once things go green

[TomSweeneyRedHat]

@mheon @rhatdan any guesses on how to fix an unsafe ptr in Docker vendored code?

[+0002s] CGO_ENABLED=0 GOOS=windows GO111MODULE=on go build -mod=vendor -gcflags 'all=-trimpath=/go/src/github.com/containers/libpod' -asmflags 'all=-trimpath=/go/src/github.com/containers/libpod' -ldflags '-X github.com/containers/libpod/libpod/define.gitCommit=2db80d6848a2c1429ca109f43473f85a28a9ce39 -X github.com/containers/libpod/libpod/define.buildInfo=1576269722 -X github.com/containers/libpod/libpod/config._installPrefix=/usr/local -X github.com/containers/libpod/libpod/config._etcDir=/etc -extldflags ""' -tags "remoteclient containers_image_openpgp exclude_graphdriver_devicemapper" -o bin/podman-remote-windows.exe github.com/containers/libpod/cmd/podman
[+0025s] # github.com/docker/docker/pkg/system
[+0025s] vendor/github.com/docker/docker/pkg/system/filesys_windows.go:112:24: cannot use uintptr(unsafe.Pointer(&sd[0])) (type uintptr) as type *"golang.org/x/sys/windows".SECURITY_DESCRIPTOR in assignment
[+0044s] make: *** [Makefile:182: podman-remote-windows] Error 2

[mheon]

Wait, is this the golang x/sys/unix breaking change? @vrothberg

[TomSweeneyRedHat]

I didn't add any vendored Docker code, but did add

[TomSweeneyRedHat]

I didn't add and vendored Docker code, but did add :

vendor/golang.org/x/sys/unix/
vendor/golang.org/x/sys/windows/

and a variety of vendor/github.com/containers.

[TomSweeneyRedHat]

FWIW, in a vein hope, I restarted the test.

[TomSweeneyRedHat]

I'm not sure what to do to fix this one, if someone has a thought, please let me know.

[rhatdan]

I think @vrothberg and @mtrmac have struggled with this in the past as well.

[vrothberg]

It's the x/sys dependency causing it, see containers/storage@54d76b1.

[TomSweeneyRedHat]

Closing in favor of #4730