Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.6] bump c/storage to v1.13.6 #4671

Merged

Conversation

vrothberg
Copy link
Member

Signed-off-by: Valentin Rothberg [email protected]

@mheon @baude PTAL

@mheon
Copy link
Member

mheon commented Dec 10, 2019

LGTM once things go green.

@mheon
Copy link
Member

mheon commented Dec 10, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@mheon
Copy link
Member

mheon commented Dec 10, 2019

I think CI on the 1.6 branch might be having problems. Probably safe to update the images to the latest ones we use for master?

@mheon
Copy link
Member

mheon commented Dec 10, 2019

Oh. I think it's just the Fedora 29 tests. Because we stopped testing on F29.

@mheon
Copy link
Member

mheon commented Dec 10, 2019

#4670 has a patch to fix CI

@mheon
Copy link
Member

mheon commented Dec 11, 2019

#4670 is landed, rebase and CI should go green

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member Author

#4670 is landed, rebase and CI should go green

Done ✔️

@mheon
Copy link
Member

mheon commented Dec 11, 2019

Restarted flake

@TomSweeneyRedHat
Copy link
Member

LGTM all green.

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@TomSweeneyRedHat
Copy link
Member

/hold
will let @mheon hit the cancel

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7d84485 into containers:v1.6 Dec 11, 2019
@mheon
Copy link
Member

mheon commented Dec 11, 2019

...It merged? Well, that doesn't seem right.

@mheon
Copy link
Member

mheon commented Dec 11, 2019

(Ah well, I was going to merge anyways...)

@mheon
Copy link
Member

mheon commented Dec 11, 2019

For sequencing, we're going to cut 1.6.4 first, then 1.7.0 immediately after - so autobuild scripts won't unintentionally obsolete 1.7.0 when the 1.6.4 tag appears

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants