Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang.org/x/sys to 14da1ac737cc #4658

Closed
wants to merge 1 commit into from
Closed

Update golang.org/x/sys to 14da1ac737cc #4658

wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

To avoid cross compilation issues again we now vendor the latest
version of the sys package.

Refers to seccomp/containers-golang#23 (comment)

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saschagrunert
To complete the pull request process, please assign baude
You can assign the PR to them by writing /assign @baude in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert mentioned this pull request Dec 9, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 9, 2019
@vrothberg
Copy link
Member

@saschagrunert, the cross-compilation errors are in the latest versions. We need to stick on older versions until docker/docker has a fix for it.

@saschagrunert saschagrunert force-pushed the x-sys branch 2 times, most recently from cc71728 to fa0b0d7 Compare December 9, 2019 09:22
@saschagrunert saschagrunert changed the title Update golang.org/x/sys to eeba5f6aabab WIP: Update golang.org/x/sys to eeba5f6aabab Dec 9, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2019
@saschagrunert saschagrunert force-pushed the x-sys branch 4 times, most recently from 47ca7be to 19491a1 Compare December 9, 2019 10:05
@saschagrunert
Copy link
Member Author

This seems to be the commit breaking the build: golang/sys@5c00192

@saschagrunert saschagrunert changed the title WIP: Update golang.org/x/sys to eeba5f6aabab Update golang.org/x/sys to 14da1ac737cc Dec 9, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2019
@saschagrunert
Update golang.org/x/sys to 14da1ac737cc
74d0294 
To avoid cross compilation issues again we now vendor the latest
version of the sys package.

Signed-off-by: Sascha Grunert <[email protected]>
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #4730) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2019
@openshift-ci-robot
Copy link
Collaborator

@saschagrunert: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented Dec 19, 2019

I think @vrothberg has fixed this issue, closing.

@rhatdan rhatdan closed this Dec 19, 2019
@saschagrunert saschagrunert deleted the x-sys branch December 19, 2019 18:27
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe Awaiting requested review from giuseppe

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

Assignees
No one assigned
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @openshift-ci-robot @vrothberg @rh-atomic-bot @rhatdan