Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not initialize store on rootless podman #4597

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

saschagrunert
Copy link
Member

This fixes a double-locking issue of the container storage when running
rootless podman.

Closes #4591

This fixes a double-locking issue of the container storage when running
rootless podman.

Closes containers#4591

Signed-off-by: Sascha Grunert <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2019

LGTM
@giuseppe PTAL

@giuseppe
Copy link
Member

thanks for addressing this issue.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2019
@baude
Copy link
Member

baude commented Nov 29, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7b99ef0 into containers:master Nov 29, 2019
@saschagrunert saschagrunert deleted the nostore branch November 29, 2019 13:57
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rootless runs execute storage.GetStore() twice (locking issue)
6 participants