WIP: Volume Plugins #4548
WIP: Volume Plugins #4548
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
☔ The latest upstream changes (presumably #4538) made this pull request unmergeable. Please resolve the merge conflicts. |
openshift-ci-robot
added
the
needs-rebase
This is not at all integrated with the rest of Libpod, but has most of what we need to talk to a volume plugin; the remainder is all around discovering plugins. There's some cleanup that can be done in how we handle responses; a lot can probably be refactored into a shared function, and I think we probably ought to be checking the response ContentType to verify the API version is correct (probably not necessary, I don't think we're likely to see a bump of the API version any time soon). Testing this in the repo is going to prove exceedingly difficult, given that we need to set up an external HTTP server to test against. Given potentially complexity, I'll do it in a separate commit. Signed-off-by: Matthew Heon <[email protected]>
Initially, use them for querying volume mountpoint and mounting volumes. Requires significant changes to several existing function signatures, which constitute the majority of the changes here. Signed-off-by: Matthew Heon <[email protected]>
openshift-ci-robot
removed
the
needs-rebase
|
☔ The latest upstream changes (presumably #4568) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@mheon: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
This pull request had no activity for 30 days. In the absence of activity or the "do-not-close" label, the pull request will be automatically closed within 7 days. |
|
@mheon You still working on this? |
|
Less actively - I'm switching over to APIv2 to unblock Brent and Jhon
…On Sat, Dec 28, 2019, 07:10 Daniel J Walsh ***@***.***> wrote:
@mheon <https://github.com/mheon> You still working on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4548>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCC3LFIWV6OWAW6UEFDQ246ZZANCNFSM4JQJI3JA>
.
|
|
Guys, any progress on this? The lack of NFS volumes blocks us from deploying our ABAP systems. |
|
NFS volumes are a separate issues and have been working for a while (Podman 1.7 or 1.8, I forget which) |
|
Oh, yeah, sorry, I had old information from colleagues of mine and I didn't bother to re-test. |
|
Closing in favor of #8357 |
github-actions
bot
added
the
locked - please file new issue/PR
For now, only the skeleton which we use to contact individual plugins. The bits that actually connect to Libpod are going to be exceedingly difficult to get right, given the volumes only "sort of" exist in Libpod and the database (primary management is delegated elsewhere, which is something that was definitely not in mind we we originally wrote Libpod).