-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --force flag to images prune #4519
Conversation
Add a -f, --force flag to images prune. As there was previously no prompt to force prune images, this commit does nothing to add such a question, only make the cli command compatible with docker cli. Resolves containers#4410 Signed-off-by: Tyler Ramer <[email protected]>
Hi @tylarb. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tylarb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is a failure - but it's not in anything I added, rather in containers prune. Looks like the test is here: "test/e2e/prune_test.go"
|
/assign @mrunalp |
Just noticed as well that #4512 is related to this PR. |
Add a -f, --force flag to images prune. As there was previously no
prompt to force prune images, this commit does nothing to add such a
question, only make the cli command compatible with docker cli.
Resolves #4410
Signed-off-by: Tyler Ramer [email protected]
Commentary
I can adjust the commit to include a prompt if --force is not included, so the cli is not just compatible with docker cli but identical.
However, if you want to add this, I wanted to propose the following thoughts:
image prune
cli not needing a--force
flag - is it important to keep this cli backwards compatibility in that case?