stats: report correctly CPU usage #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the two values were incorrectly switched. Signed-off-by: Giuseppe Scrivano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
Can you add tests for this. So we avoid regressions in the future? |
mheon
reviewed
Nov 1, 2019
Closes: containers#4409 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
fix-cpu-stats
branch
from
d8ca879 to
a84ab35
Compare
I've tried to add one, but it seems quite tricky. |
|
LGTM |
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Mar 2, 2022
[NO NEW TESTS NEEDED} Backport of containers#4423 to the v1.6.4-rhel branch so that it can be included into RHEL 8.2 This fixes the was that CPU is reported from the `podman stats` command. This fix was first put into podman v1.7.0 Addresses https://bugzilla.redhat.com/show_bug.cgi?id=2060095 Signed-off-by: tomsweeneyredhat <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4409
Signed-off-by: Giuseppe Scrivano [email protected]