Attach to container if it was created with --interactive

[tylarb]

Check to see if the container's start config includes the interactive
flag when determining to attach or ignore stdin stream.

This is in line with behavior of Docker CLI and engine

Signed-off-by: Tyler Ramer [email protected]

---

Addresses #4259

[openshift-ci-robot]

Hi @tylarb. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tylarb]

/assign @rhatdan

[baude]

/ok-to-test

[baude]

i would prefer a better commit message that tells us why we need to change behavior. is it because docker does it or ?

[tylarb]

Suggested re-write of commit message:

Check to see if the container's start config includes the interactive
flag when determining to attach or ignore stdin stream.

This is in line with behavior when creating a container using Docker engine.

Docker does seem to propogate the -i flag for a container created with it:

libpod(stdin_attach)$ docker --version
Docker version 19.03.3-ce, build a872fc2f86
libpod(stdin_attach)$ docker create -it --name centos_test centos
bd62bc6f3804ca2f20200b96dd0551435a19480b46052fc19ec7628ebbe7976d
libpod(stdin_attach)$ docker start -a centos_test
[root@bd62bc6f3804 /]# ls asdfl;kjasdf
^C

vs podman (current version) -

workspace$ podman --version
podman version 1.6.1
workspace$ podman start -a centos_test        
[root@45e4833f49cb /]# %                     # podman stop centos_test in another terminal                                                                                                                                                                                                              
workspace$ lslsldflkj;asdf;ljasdflkjdsfjjf
zsh: command not found: lslsldflkj

On the version of docker I'm using, it does NOT seem to pass stdout... so the command is entered, but the results are not returned, interestingly enough. But this would be a bug in docker, I assume.

Compared to the patch:

[root@localhost bin]# ./podman --version 
podman version 1.6.2-dev

[root@localhost bin]# ./podman create -it --name centos_test centos
5080ccbc5f0f6cec4f0a50fc0e7334d71879b91e86e8768636d3ddf5e1fc6d21

[root@localhost bin]# ./podman start -a centos_test
[root@5080ccbc5f0f /]# ls
bin  dev  etc  home  lib  lib64  lost+found  media  mnt  opt  proc  root  run  sbin  srv  sys  tmp  usr  var

[tylarb]

Commit message updated.

[rhatdan]

@mheon @giuseppe PTAL
Thanks @tylarb

[mheon]

This LGTM

[mheon]

/lgtm

[rhatdan]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, tylarb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment