Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman network create: validate user input #4188

Merged
merged 1 commit into from
Oct 4, 2019
Merged

podman network create: validate user input #4188

merged 1 commit into from
Oct 4, 2019

Conversation

Mrigank11
Copy link
Contributor

Disallow invalid/confusing names such as '../bar' or 'foo '
Closes #4184

Signed-off-by: Mrigank Krishan [email protected]

@openshift-ci-robot
Copy link
Collaborator

Hi @Mrigank11. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 3, 2019
mheon
mheon reviewed Oct 3, 2019
View reviewed changes
cmd/podman/network_create.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Oct 3, 2019
View reviewed changes
cmd/podman/network_create.go Outdated Show resolved Hide resolved
@mheon
Copy link
Member

mheon commented Oct 3, 2019

/approve
/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, Mrigank11

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2019
@TomSweeneyRedHat
Copy link
Member

/ok-to-test

@TomSweeneyRedHat
Copy link
Member

Other than @mheon's comments and the gating issue, LGTM

@Mrigank11 Mrigank11 force-pushed the validate_network_name branch from 83e1986 to 6674c5a Compare October 3, 2019 21:01
@Mrigank11
podman network create: validate user input
c5e26f8 
Disallow invalid/confusing names such as '../bar' or 'foo '
Closes containers#4184

Signed-off-by: Mrigank Krishan <[email protected]>
@Mrigank11 Mrigank11 force-pushed the validate_network_name branch from 6674c5a to c5e26f8 Compare October 3, 2019 21:04
@baude
Copy link
Member

baude commented Oct 3, 2019

what is wrong with a network named foo ?

@mheon
Copy link
Member

mheon commented Oct 3, 2019

@baude Trailing space

@mheon
Copy link
Member

mheon commented Oct 3, 2019

LGTM

vrothberg
vrothberg reviewed Oct 4, 2019
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2019
@rhatdan
Copy link
Member

rhatdan commented Oct 4, 2019

Thanks @Mrigank11 for the PR.

@openshift-merge-robot openshift-merge-robot merged commit 1fe9556 into containers:master Oct 4, 2019
@jjwatt jjwatt mentioned this pull request Apr 18, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@mheon mheon mheon left review comments

@jwhonce jwhonce Awaiting requested review from jwhonce

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman network create: should validate input
8 participants
@Mrigank11 @openshift-ci-robot @mheon @TomSweeneyRedHat @baude @rhatdan @vrothberg @openshift-merge-robot