-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .travis.yml to test podman deb package on Ubuntu with Travis CI. #4160
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: junaruga The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @junaruga. Thanks for your PR. I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Jun Aruga <[email protected]>
628c9d3
to
d758f61
Compare
/ok-to-test |
do I read this correctly that you wish to enable testing on travis for libpod? if so, i am not supportive of this. other team-members will also weigh in. |
Aren't we testing Ubuntu already on Cirrus? |
Ah, I see the intent here - to verify Podman actually works in Travis. Hm. |
Yes. Actually this repository'sTravis CI is already enabled. Maybe someone did it in a past time.
Oh why? It's useful for me and other people to see examples of podman on Travis CI, and to check issue for podman deb package. |
Yes. That's the intent. :) |
@junaruga can you tell me what you are really trying to do here? My interpretation is you want to protect regressions for debian by testing an ubuntu package that is already been built? If I understand that correctly, then this would be the wrong place to do that. The tests being run here are meant to test new code being proposed for the upstream project. each of the tests you want to run, I believe are tested on the upstream code on ubuntu. i think what you are wanting is some sort of gating tests for ubuntu/debian. is that more accurate? |
Yes. right. "some sort of gating tests for ubuntu/debian" is my intent.
I wanted to run podman and podman-compose on Travis CI for my project. |
I am okay to close this PR. The motivation of the PR was @rhatdan 's comment "We would love to have this added to libpod for testing." here. |
@junaruga he is travelling today so lets give him some time to get back and consider the proposal. im not the only vote here |
@junaruga Could we do the testing you want through cirrus? We have had problems with travis in the patch causing huge delays in merging of PRs. We were experiencing that, just yesterday, on buildah and containers/image. We are paying for some testing on cirrus and tend to get much better though put. Getting better integration between podman-compose and podman for regression testing would be nice, and getting integration into podman-machine, since those projects are taking pressure off of the core teams. |
I interpreted the initial request to open a pull request that adds documention how to run podman in Travis, not to actually run it in Travis. |
@vrothberg yes right. I intended 2 PRs. One PR was for the initial request for the documentation.
@rhatdan yes let me see the Cirrus code at first. I misunderstood you wanted Travis CI testing for this repository libpod. :) Thanks for the detailed explanation. So, I would like to close this PR. I will send new PRs later. |
Add
.travis.yml
to test Ubuntu deb package.It's related to #3679 (comment) .
I found bionic is available on Travis CI.
https://docs.travis-ci.com/user/reference/bionic/
https://github.com/travis-ci/docs-travis-ci-com/tree/master/user/reference
So, this
.travis.yml
has total 6 cases (4 cases for xenial, and 2 cases for bionic).Here is the result on my forked repository.
https://travis-ci.org/junaruga/libpod/builds/592091305
As I got below error for bionic root case, I added it as allow failures. That's why this
.travis.yml
exists. :)https://travis-ci.org/junaruga/libpod/jobs/592091311#L543
I added Travis badge image to
README.md
that is useful to see the build status easily.Here is the modified
README.md
.https://github.com/junaruga/libpod/blob/feature/add-travis-ci/README.md
I did not add qemu cases that exist in the example #3679 (comment) to simply the cases.
Travis "addon" syntax used for this PR might not be reliable to install deb packages.
For example ruby project is using own commands to control a retry logic of the commands.
https://github.com/ruby/ruby/blob/master/.travis.yml#L71-L89
Could you review this PR?
The actual documentation to run podman on Travis CI will be later by another PR after this PR will be merged.
Thanks.