Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play kube: Only support pod kind in k8s yaml #4094

Merged

Conversation

haircommander
Copy link
Collaborator

Since we only really support playing pods, and no other kubernetes types

fixes #4093

Signed-off-by: Peter Hunt [email protected]

Since we only really support playing pods, and no other kubernetes types

Signed-off-by: Peter Hunt <[email protected]>
@mheon
Copy link
Member

mheon commented Sep 24, 2019

/approve
LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019
@mheon
Copy link
Member

mheon commented Sep 24, 2019

We might want to look into expanding play kube to other YAML in the future, so it might be worth keeping the issue open as an enhancement

@haircommander
Copy link
Collaborator Author

haircommander commented Sep 24, 2019

I think rescoping the issue as an enhancement would be best. We could create a list of possible yaml kinds we could support. As of now, it reads like a bug
Edit: I am wrong, it does read like an enhancement, but I think having our own issue to track ones we want to support in one place would be good

@TomSweeneyRedHat
Copy link
Member

LGTM and all happy green test buttons.

@aric49
Copy link

aric49 commented Sep 24, 2019

@haircommander -- I agree. I think that Podman in a future release should support the Kubernetes deployment spec as well as the pod spec. I think a good stop gap is throwing the error message you have in this PR, but the vast majority of Kubernetes deployments (at least that I've seen) all use the deployment spec.

@mheon
Copy link
Member

mheon commented Sep 24, 2019

/lgtm
I'll reopen #4093 once this closes it, and retag as enhancement

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1dfac0e into containers:master Sep 24, 2019
@rhatdan
Copy link
Member

rhatdan commented Sep 25, 2019

@haircommander Would you like to look into supporting the Deployment spec?

@haircommander
Copy link
Collaborator Author

@rhatdan sure, as time allows 😄

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman Support for K8s "Deployment" specification
7 participants