-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
play kube: Only support pod kind in k8s yaml #4094
play kube: Only support pod kind in k8s yaml #4094
Conversation
Since we only really support playing pods, and no other kubernetes types Signed-off-by: Peter Hunt <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We might want to look into expanding |
I think rescoping the issue as an enhancement would be best. We could create a list of possible yaml kinds we could support. |
LGTM and all happy green test buttons. |
@haircommander -- I agree. I think that Podman in a future release should support the Kubernetes deployment spec as well as the pod spec. I think a good stop gap is throwing the error message you have in this PR, but the vast majority of Kubernetes deployments (at least that I've seen) all use the deployment spec. |
/lgtm |
@haircommander Would you like to look into supporting the Deployment spec? |
@rhatdan sure, as time allows 😄 |
Since we only really support playing pods, and no other kubernetes types
fixes #4093
Signed-off-by: Peter Hunt [email protected]