When first mounting any named volume, copy up #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
mheon
force-pushed
the
copy_volume_contents
branch
from
a8a4a69 to
13a7ee5
Compare
|
LGTM |
|
LGTM assuming happy tests |
mheon
force-pushed
the
copy_volume_contents
branch
from
13a7ee5 to
c56bedd
Compare
|
Hold merging for a bit, want to add some tests - seeing some wierd things in CI which makes me think we might have edge cases |
mheon
force-pushed
the
copy_volume_contents
branch
2 times, most recently
from
738513b to
baa073e
Compare
|
Tests added |
mheon
force-pushed
the
copy_volume_contents
branch
2 times, most recently
from
7c856dd to
9167377
Compare
Previously, we only did this for volumes created at the same time as the container. However, this is not correct behavior - Docker does so for all named volumes, even those made with 'podman volume create' and mounted into a container later. Fixes containers#3945 Signed-off-by: Matthew Heon <[email protected]>
mheon
force-pushed
the
copy_volume_contents
branch
from
9167377 to
b610634
Compare
|
Found the problem, tests should go green now. |
|
LGTM assuming happy tests |
|
/retest Prow tests seem to be hanging... |
|
/retest |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only did this for volumes created at the same time as the container. However, this is not correct behavior - Docker does so for all named volumes, even those made with 'podman volume create' and mounted into a container later.
Fixes #3945