Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update varlink doc and code for images #3888

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Aug 26, 2019

  • Improved error message
  • Added documentation
  • Updated messages to include missing data

This PR is required before it's peer can be merged in python-podman

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce self-assigned this Aug 26, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S labels Aug 26, 2019
* Improved error message
* Added documentation
* Updated messages to include missing data

Signed-off-by: Jhon Honce <[email protected]>
@baude
Copy link
Member

baude commented Aug 27, 2019

lgtm, good work

@rhatdan
Copy link
Member

rhatdan commented Aug 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@openshift-merge-robot openshift-merge-robot merged commit f221c61 into containers:master Aug 27, 2019
@jwhonce jwhonce deleted the wip/api branch June 30, 2021 16:13
@jwhonce jwhonce restored the wip/api branch June 30, 2021 16:13
@jwhonce jwhonce deleted the wip/api branch June 30, 2021 16:13
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants