Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Pod hostname as Pod name #3818

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

chenzhiwei
Copy link
Contributor

Fixes #3732

Signed-off-by: Chen Zhiwei [email protected]

Signed-off-by: Chen Zhiwei <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

Hi @chenzhiwei. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 15, 2019
@chenzhiwei
Copy link
Contributor Author

/assign @haircommander @QiWang19

@rh-atomic-bot
Copy link
Collaborator

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@rhatdan
Copy link
Member

rhatdan commented Aug 15, 2019

bot, add author to whitelist

@rhatdan
Copy link
Member

rhatdan commented Aug 15, 2019

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM, remote tests are unhappy, but I don't think it's related.

@baude
Copy link
Member

baude commented Aug 15, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, chenzhiwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2019
@baude
Copy link
Member

baude commented Aug 15, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2019
@haircommander
Copy link
Collaborator

LGTM
though i'd say this is a partial fix (we should eventually allow users to configure the hostbame, as a kubernetes pod, separate from name), this is a good start. Thanks @chenzhiwei

@chenzhiwei
Copy link
Contributor Author

@haircommander Yes, the other part of fix should consider the hostNetwork and hostname in Pod Spec, but this will be a little complex.

@mheon
Copy link
Member

mheon commented Aug 15, 2019

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Aug 15, 2019
@mheon
Copy link
Member

mheon commented Aug 15, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2019
@openshift-merge-robot openshift-merge-robot merged commit 74224d9 into containers:master Aug 15, 2019
@chenzhiwei chenzhiwei deleted the hostname branch August 16, 2019 14:30
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow setting hostname for a pod
10 participants