Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document SELinux label requirements for the rootfs argument #3631

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Document SELinux label requirements for the rootfs argument #3631

merged 1 commit into from
Jul 25, 2019

Conversation

TristanCacqueray
Copy link
Contributor

When using the rootfs argument, SELinux systems fails silently
when the files are not properly labeled.

Related #3628

Signed-off-by: Tristan Cacqueray [email protected]

@openshift-ci-robot
Copy link
Collaborator

Hi @TristanCacqueray. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2019
@rh-atomic-bot
Copy link
Collaborator

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@haircommander
Copy link
Collaborator

/ok-to-test
bot, test pull request

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2019
@mheon
Copy link
Member

mheon commented Jul 23, 2019

/approve

@mheon
Copy link
Member

mheon commented Jul 23, 2019

LGTM, but I'd like a signoff from @rhatdan

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, TristanCacqueray

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@giuseppe
Copy link
Member

/ok-to-test

LGTM

@giuseppe
Copy link
Member

@TristanCacqueray the failures don't seem related to this PR. Could you please rebase and push again?

@rhatdan
Copy link
Member

rhatdan commented Jul 24, 2019

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jul 24, 2019

I think this needs a rebase to fix the latest lint errors.

@TristanCacqueray
Document SELinux label requirements for the rootfs argument
e206783 
When using the rootfs argument, SELinux systems fails silently
when the files are not properly labeled.

Related #3628

Signed-off-by: Tristan Cacqueray <[email protected]>
@TomSweeneyRedHat
Copy link
Member

LGTM, fingers crossed that the rebase chased the lint errors away.

@rhatdan
Copy link
Member

rhatdan commented Jul 25, 2019

/lgtm
Thanks @TristanCacqueray

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@openshift-merge-robot openshift-merge-robot merged commit 5763618 into containers:master Jul 25, 2019
@edsantiago edsantiago mentioned this pull request Sep 12, 2022
Merged
edsantiago added a commit to edsantiago/libpod that referenced this pull request Sep 12, 2022
@edsantiago
Man pages: refactor common options: --rootfs
09ba2e0 
podman-create and -run only. The SELinux text was added
to podman-run (but not -create) in containers#3631, and reformatted
in containers#5192. I assume here that it also applies to podman-create.

Per feedback from Dan, added :s0 to SELinux context

Signed-off-by: Ed Santiago <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe Awaiting requested review from giuseppe

@jwhonce jwhonce Awaiting requested review from jwhonce

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@TristanCacqueray @openshift-ci-robot @rh-atomic-bot @haircommander @mheon @giuseppe @rhatdan @TomSweeneyRedHat @openshift-merge-robot