rootless: enable linger if /run/user/UID not exists #3397
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
LGTM assuming happy tests. |
giuseppe
force-pushed
the
fix-reboot
branch
7 times, most recently
from
0d11319 to
6125cd8
Compare
|
/lgtm |
openshift-ci-robot
added
do-not-merge/hold
giuseppe
force-pushed
the
fix-reboot
branch
2 times, most recently
from
67ccb3d to
821514c
Compare
giuseppe
force-pushed
the
fix-reboot
branch
2 times, most recently
from
327d873 to
bf40ee3
Compare
|
tests are green |
|
/lgtm |
|
|
||
| runtimeDir := os.Getenv("XDG_RUNTIME_DIR") | ||
|
|
||
| runtimeDirLinger, err := rootless.EnableLinger() |
There was a problem hiding this comment.
Should mention this in the comment
There was a problem hiding this comment.
would you like a comment about what runtimeDirLinger is?
There was a problem hiding this comment.
I'd like something in the function's header comment to indicate that SetXdgRuntimeDir() also calls EnableLinger() - so we know where the call is happening from the docs.
|
Too late, sorry - just merged the tag. |
|
We're probably going to need a 1.4.4 with the runc fixes, though - might be able to sneak this in there |
|
@rhatdan anything left to do here or we can merge? |
|
/lgtm |
|
it is still on hold |
|
☔ The latest upstream changes (presumably #3446) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Oops @giuseppe looks like you need a rebase |
openshift-ci-robot
removed
the
do-not-merge/hold
|
☔ The latest upstream changes (presumably #3442) made this pull request unmergeable. Please resolve the merge conflicts. |
at least on Fedora 30 it creates the /run/user/UID directory for the user logged in via ssh. This needs to be done very early so that every other check when we create the default configuration file will point to the correct location. Closes: containers#3410 Signed-off-by: Giuseppe Scrivano <[email protected]>
|
rebased |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
at least on Fedora 30 it creates the /run/user/UID directory for the
user logged in via ssh.
This needs to be done very early so that every other check when we
create the default configuration file will point to the correct
location.
Signed-off-by: Giuseppe Scrivano [email protected]