Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build podman-remote with Dockerfile. #2975

Conversation

kunalkushwaha
Copy link
Collaborator

build podman-remote binaries for linux & darwin in container

Signed-off-by: Kunal Kushwaha [email protected]

@kunalkushwaha kunalkushwaha changed the title build podman-remote with Dockefile. build podman-remote with Dockerfile. Apr 19, 2019
@kunalkushwaha kunalkushwaha force-pushed the containerized-podman-remote-build branch from d41b4b1 to b8389e5 Compare April 19, 2019 02:49
@rhatdan
Copy link
Member

rhatdan commented Apr 19, 2019

LGTM
@mheon @baude @jwhonce @TomSweeneyRedHat PTAL

@TomSweeneyRedHat
Copy link
Member

/approved

@TomSweeneyRedHat
Copy link
Member

Tests aren't happy @kunalkushwaha , I'm not sure what's up but I don't think it's a flake.

@rhatdan
Copy link
Member

rhatdan commented Apr 20, 2019

No this is a known issue with runc and a patch I added to it, where it attempts to write to keycreate on non SELinux systems

@kunalkushwaha
Copy link
Collaborator Author

is this runc PR opencontainers/runc#2012 will fix this CI issue?

@mheon
Copy link
Member

mheon commented Apr 23, 2019

The failures are for Podman-in-Podman testing, which should be SELinux disabled - I know that there were separate fixes for SELinux enabled and disabled, so I'm not sure if this is the right one

@rhatdan
Copy link
Member

rhatdan commented Apr 23, 2019

Right the issue is there is an older version of container-selinux on these images. I don't know how we force an upgrade.

@mheon
Copy link
Member

mheon commented Apr 23, 2019

The failing test is container-in-container. I'm fairly confident the outer container is installing fresh from the repos every test, so we need to update the host, i suppose

@rhatdan
Copy link
Member

rhatdan commented Apr 25, 2019

@kunalkushwaha You need to rebase the PR, and it will pass the tests.

git pull origin master
git rebase -i origin
git push --force

build podman-remote binaries for linux & darwin in container

Signed-off-by: Kunal Kushwaha <[email protected]>
@kunalkushwaha kunalkushwaha force-pushed the containerized-podman-remote-build branch from b8389e5 to 4f7cbce Compare April 25, 2019 08:45
@kunalkushwaha
Copy link
Collaborator Author

Thanks. All tests are happy now :)

@mheon
Copy link
Member

mheon commented Apr 25, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2019
@mheon
Copy link
Member

mheon commented Apr 25, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunalkushwaha, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@openshift-merge-robot openshift-merge-robot merged commit d08efde into containers:master Apr 25, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants