-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build podman-remote with Dockerfile. #2975
build podman-remote with Dockerfile. #2975
Conversation
d41b4b1
to
b8389e5
Compare
LGTM |
/approved |
Tests aren't happy @kunalkushwaha , I'm not sure what's up but I don't think it's a flake. |
No this is a known issue with runc and a patch I added to it, where it attempts to write to keycreate on non SELinux systems |
is this runc PR opencontainers/runc#2012 will fix this CI issue? |
The failures are for Podman-in-Podman testing, which should be SELinux disabled - I know that there were separate fixes for SELinux enabled and disabled, so I'm not sure if this is the right one |
Right the issue is there is an older version of container-selinux on these images. I don't know how we force an upgrade. |
The failing test is container-in-container. I'm fairly confident the outer container is installing fresh from the repos every test, so we need to update the host, i suppose |
@kunalkushwaha You need to rebase the PR, and it will pass the tests. git pull origin master |
build podman-remote binaries for linux & darwin in container Signed-off-by: Kunal Kushwaha <[email protected]>
b8389e5
to
4f7cbce
Compare
Thanks. All tests are happy now :) |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunalkushwaha, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
build podman-remote binaries for linux & darwin in container
Signed-off-by: Kunal Kushwaha [email protected]