Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print header for 'podman images' even with no images present #2879

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Print header for 'podman images' even with no images present #2879

merged 1 commit into from
Apr 11, 2019

Conversation

mheon
Copy link
Member

@mheon mheon commented Apr 9, 2019

Fixes #2877

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS labels Apr 9, 2019
@TomSweeneyRedHat
Copy link
Member

LGTM assuming happy tests.
Should we add a test for this?

@mheon
Copy link
Member Author

mheon commented Apr 9, 2019

@TomSweeneyRedHat well, I have to go into the tests anyways... Looks like a few of them are expected 0 lines back for images with nothing present

@mheon mheon force-pushed the header_on_no_images branch from a1d4f58 to 1dd54f1 Compare April 9, 2019 18:51
vrothberg
vrothberg reviewed Apr 10, 2019
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM but some pre-existing tests need to be adjusted.

test/e2e/images_test.go
session := podmanTest.Podman([]string{"images"})
session.WaitWithDefaultTimeout()
Expect(session.ExitCode()).To(Equal(0))
Expect(len(session.OutputToStringArray())).To(Equal(1))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other tests are failing because they expect .To(Equal(0)) which doesn't hold anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing -a with -aq where I can - quiet output still prints nothing when 0 images are present

@mheon mheon force-pushed the header_on_no_images branch from 1dd54f1 to ba4a1bb Compare April 10, 2019 13:56
@rhatdan
Copy link
Member

rhatdan commented Apr 10, 2019

LGTM

@rhatdan
Copy link
Member

rhatdan commented Apr 11, 2019

/lgtm

@rhatdan
Copy link
Member

rhatdan commented Apr 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@rhatdan
Copy link
Member

rhatdan commented Apr 11, 2019

Test

@rhatdan
Copy link
Member

rhatdan commented Apr 11, 2019

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit ab25998 into containers:master Apr 11, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mheon @openshift-ci-robot @TomSweeneyRedHat @rhatdan @vrothberg @openshift-merge-robot