Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system df: reject invalid arguments #2777

Merged

Conversation

edsantiago
Copy link
Member

Signed-off-by: Ed Santiago [email protected]

@mheon
Copy link
Member

mheon commented Mar 27, 2019

/approve
LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2019
@mheon
Copy link
Member

mheon commented Mar 27, 2019

@baude @rhatdan @TomSweeneyRedHat PTAL

@edsantiago
Copy link
Member Author

In case context helps for reviewing:

$ grep -Rh -3 noSubArgs cmd/podman

@TomSweeneyRedHat
Copy link
Member

LGTM
Test out nicely, nice little fix @edsantiago

@mheon
Copy link
Member

mheon commented Mar 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@openshift-merge-robot openshift-merge-robot merged commit 850326c into containers:master Mar 28, 2019
@edsantiago edsantiago deleted the system_df_invalid_arg branch April 9, 2019 11:15
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants