Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] vendor containers/{image,storage} #2763

Closed
wants to merge 1 commit into from

Conversation

vrothberg
Copy link
Member

Avoid redundantly pulling the same image (or layer).

Signed-off-by: Valentin Rothberg [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2019
@vrothberg
Copy link
Member Author

Do not merge this PR, it's used to increase confidence for the changes to storage and image by letting it pass libpod's CI.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 26, 2019
@vrothberg
Copy link
Member Author

Need to fix up some things in the PR and merge containers/buildah#1400 first to unblock.

@mheon
Copy link
Member

mheon commented Mar 26, 2019

@vrothberg I'll mark this as WIP then

@mheon mheon changed the title vendor containers/{image,storage} [WIP] vendor containers/{image,storage} Mar 26, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2019
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #2789) made this pull request unmergeable. Please resolve the merge conflicts.

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #2802) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2019
@vrothberg vrothberg force-pushed the copy-detection branch 2 times, most recently from e29e119 to 8a1c0a8 Compare April 2, 2019 12:24
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2019
@vrothberg
Copy link
Member Author

bot, retest this please

Requires to vendor containers/image, storage and the latest
version of the progress bar library.

Signed-off-by: Valentin Rothberg <[email protected]>
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #2931) made this pull request unmergeable. Please resolve the merge conflicts.

@vrothberg
Copy link
Member Author

Closing in favour of Closing in favour of containers/image#611.

@vrothberg vrothberg closed this Apr 18, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants