Need to pass the true paramater with --syslog in cobra

[rhatdan]

Currently cobra can not handle a boolean option without a vailue.

This change fixes an issue if you want syslog information to show up
based on the cleanup call.

Signed-off-by: Daniel J Walsh [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@edsantiago @baude PTAl

[TomSweeneyRedHat]

LGTM

[edsantiago]

This is beyond my ken. I have no experience with the code under pkg, and am not sure what the context is for this fix. (It has no effect on podman --syslog version; AFAICT this is passing on to a subsequent podman call but I can't find it).

[edsantiago]

I'm still confused, but I'm giving up. According to this cobra comment what we're seeing should not happen: cobra should require an equals sign, not just blindly gobble the next arg. According to my reading of spf13/pflag/command.go, I think something isn't properly grokking bools.

For extra fun, try podman --trace=false version. And with that, I'm stepping away.

[mheon]

This sounds more like a bug in Cobra than something Podman should fix, but LGTM, I suppose.

[edsantiago]

/lgtm