Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ConmonPidFile in 'podman inspect' for containers #2698

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Export ConmonPidFile in 'podman inspect' for containers #2698

merged 1 commit into from
Mar 18, 2019

Conversation

debarshiray
Copy link
Member

@debarshiray debarshiray commented Mar 18, 2019

This can help scripts provide a more meaningful message when coming
across issues [1] which require the container to be re-created.

[1] eg., #2673

Signed-off-by: Debarshi Ray [email protected]

@openshift-ci-robot openshift-ci-robot added size/S needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2019
@openshift-ci-robot
Copy link
Collaborator

Hi @debarshiray. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rh-atomic-bot
Copy link
Collaborator

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@giuseppe
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2019
@rhatdan
Copy link
Member

rhatdan commented Mar 18, 2019

Looks like inspect tests are failing?

@debarshiray
Copy link
Member Author

Looks like inspect tests are failing?

I was waiting for failing tests to confirm that inspection of containers doesn't work with podman-remote.

This can help scripts provide a more meaningful message when coming
across issues [1] which require the container to be re-created.

[1] eg., #2673

Signed-off-by: Debarshi Ray <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debarshiray, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Mar 18, 2019

LGTM

@rhatdan
Copy link
Member

rhatdan commented Mar 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit 8afe02f into containers:master Mar 18, 2019
@debarshiray debarshiray deleted the wip/rishi/podman-inspect-conmon-pid-file branch March 19, 2019 08:07
@debarshiray
Copy link
Member Author

Thanks for all the reviews!

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants