-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export ConmonPidFile in 'podman inspect' for containers #2698
Export ConmonPidFile in 'podman inspect' for containers #2698
Conversation
Hi @debarshiray. Thanks for your PR. I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch?
|
/approve |
Looks like inspect tests are failing? |
I was waiting for failing tests to confirm that inspection of containers doesn't work with |
This can help scripts provide a more meaningful message when coming across issues [1] which require the container to be re-created. [1] eg., #2673 Signed-off-by: Debarshi Ray <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debarshiray, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
/lgtm |
Thanks for all the reviews! |
This can help scripts provide a more meaningful message when coming
across issues [1] which require the container to be re-created.
[1] eg., #2673
Signed-off-by: Debarshi Ray [email protected]