Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: check containerInfo.Config before accessing it #2656

Merged

Conversation

giuseppe
Copy link
Member

check that containerInfo.Config is not nil before trying to access
it.

Closes: #2654

Signed-off-by: Giuseppe Scrivano [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2019
@mheon
Copy link
Member

mheon commented Mar 14, 2019

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM once the tests issues are solved.

@giuseppe giuseppe force-pushed the fix-rootfs-segfault branch from 7ceece9 to dd916d9 Compare March 15, 2019 01:06
check that containerInfo.Config is not nil before trying to access
it.

Closes: containers#2654

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe force-pushed the fix-rootfs-segfault branch from dd916d9 to 508e084 Compare March 15, 2019 09:39
@rhatdan
Copy link
Member

rhatdan commented Mar 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2019
@openshift-merge-robot openshift-merge-robot merged commit f4c4196 into containers:master Mar 15, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants