Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't extract tar file in podman cp #2517

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Don't extract tar file in podman cp #2517

merged 1 commit into from
Mar 4, 2019

Conversation

QiWang19
Copy link
Contributor

@QiWang19 QiWang19 commented Mar 4, 2019

fix #2509 Directly copy the tar file between container and host, do not extract tar file to the destination.
Signed-off-by: Qi Wang [email protected]

@mheon
Copy link
Member

mheon commented Mar 4, 2019

LGTM

@rhatdan
Copy link
Member

rhatdan commented Mar 4, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
TomSweeneyRedHat
TomSweeneyRedHat reviewed Mar 4, 2019
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, nice work @QiWang19

My only question is one of design for @mheon and/or @rhatdan. Extracting a tar file into a container seems like neat functionality. Can/should we add an --extract option or similar and then do the old extraction functionality in that case?

@openshift-merge-robot openshift-merge-robot merged commit 8a90f83 into containers:master Mar 4, 2019
@rhatdan
Copy link
Member

rhatdan commented Mar 4, 2019

I am fine with adding that function.

@TomSweeneyRedHat
Copy link
Member

I'll spin up an RFE issue then.

@TomSweeneyRedHat TomSweeneyRedHat mentioned this pull request Mar 4, 2019
Closed
@QiWang19 QiWang19 deleted the i2509 branch March 6, 2019 18:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@baude baude Awaiting requested review from baude

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman cp extracts tarballs, unlike docker cp command
6 participants
@QiWang19 @mheon @rhatdan @openshift-ci-robot @TomSweeneyRedHat @openshift-merge-robot