Touchup README.md and fix whitespace issues #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
bot, retest this please |
mheon
reviewed
Jan 18, 2018
Makefile
Outdated
| @@ -1,5 +1,5 @@ | |||
| GO ?= go | |||
| EPOCH_TEST_COMMIT ?= dd0d35d | |||
| EPOCH_TEST_COMMIT ?= 05317d8 | |||
There was a problem hiding this comment.
It looks like there's trailing whitespace on this. Could that make gitvalidation angry?
There was a problem hiding this comment.
did it pass gitvalidation locally ?
|
bot, retest this please |
|
Just like #230, Error on Red Hat CI without any logs/errors. Looks like the bot doesn't like me, can someone kick it please? |
|
bot, retest this please |
|
Still seeing gitvalidation errors - whitespace errors in 0aa2459 |
Signed-off-by: TomSweeneyRedHat <[email protected]>
|
Going to merge to clean up gitvalidation issues |
|
📌 Commit 2ae079f has been approved by |
|
⚡ Test exempted: pull fully rebased and already tested. |
Merged
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TomSweeneyRedHat [email protected]
README.md had a lingering whitespace issues. This will (hopefully) fix that and touches up a few other nits.