Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: flake workaround: ignore socat waitpid warnings #23777

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

edsantiago
Copy link
Member

Workaround (NOT A FIX) for pasta issue #23482, wherein
podman logs includes a waitpid: ESRCH warning. Consensus
seems to be that this is a bug in socat.

I have not seen the flake in my || PR since adding this, but now the flake is in the wild so am filing a small PR.

I hate this, because there's no timebomb or other mechanism to know if the socat bug is ever fixed, so this little workaround will stick around forever, annoying future maintainers.

Signed-off-by: Ed Santiago [email protected]

None

Copy link
Contributor

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small non blocking nit

test/system/505-networking-pasta.bats Outdated Show resolved Hide resolved
Workaround (NOT A FIX) for pasta issue containers#23482, wherein
podman logs includes a waitpid: ESRCH warning. Consensus
seems to be that this is a bug in socat.

Signed-off-by: Ed Santiago <[email protected]>
@mheon
Copy link
Member

mheon commented Aug 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f013ebe into containers:main Aug 28, 2024
61 checks passed
@edsantiago edsantiago deleted the socat-workaround branch August 28, 2024 14:27
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 27, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants