Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have pod.Name display instead of pod.ID on start and stop reports #22806

Merged
merged 2 commits into from
May 28, 2024

Conversation

JayKayy
Copy link
Contributor

@JayKayy JayKayy commented May 25, 2024

Does this PR introduce a user-facing change?

This change brings the podman pod start and podman pod stop output to be more consistent with the output of podman start and podman stop. Starting and stopping pods now print the pod name instead of the pod.ID()

Closes #22590

How to test

# create containers
./bin/podman run -d --name a nginx:latest
./bin/podman run -d --name b nginx:latest

# create a pod
./bin/podman pod create --name c
./bin/podman pod stop c && ./bin/podman stop a b  
./bin/podman pod start c && ./bin/podman start a b   

Before:

➜  ./bin/podman pod start c && podman start a b        
3013672b24bf91811dfb6f8802f23443e5847b032ad0c4217a6654cccfaa3fc7
a
b
➜  ./bin/podman pod stop c && podman stop a b       
3013672b24bf91811dfb6f8802f23443e5847b032ad0c4217a6654cccfaa3fc7
a
b

After:

➜  ./bin/podman pod start c && ./bin/podman start a b   
c
a
b
➜  ./bin/podman pod stop c && ./bin/podman stop a b  
c
a
b
Starting and stopping pods print the pod's name instead of the id.

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label May 25, 2024
@JayKayy JayKayy force-pushed the 22590-pod-console-name branch from f0eac62 to a7245da Compare May 25, 2024 10:25
@JayKayy JayKayy force-pushed the 22590-pod-console-name branch from 998e5f6 to b453642 Compare May 25, 2024 23:40
@@ -10,88 +10,88 @@ load helpers
# options both in the container podman and out here: that's the only
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes, most of this file seems to have been modified by my IDE, I'll check to see that i can disable that on save to simplify the changes.

@rhatdan
Copy link
Member

rhatdan commented May 27, 2024

Thanks @JayKayy
LGTM
/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, code LGTM but please revert the changes to test/upgrade/test-upgrade.bats

Signed-off-by: jkwiatko <[email protected]>
@JayKayy
Copy link
Contributor Author

JayKayy commented May 27, 2024

@giuseppe reverted auto-format changes

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, JayKayy, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JayKayy
Copy link
Contributor Author

JayKayy commented May 27, 2024

@giuseppe The failure in CI looks like it may be a flake. I don't believe my changes would affect WSL or podman machine directly. In reading the CONTRIBUTING.md CI it says flakes can be rerun from the details page. I do not see an option to rerun the machine-wsl podman windows rootless host sqlite on that details page. I am able to see the logs and status of the job, but unfortunately do not see a "re-run" button. Any tips on how I can trigger this again without a dummy commit?

@rhatdan
Copy link
Member

rhatdan commented May 28, 2024

I just reran it.

@openshift-merge-bot openshift-merge-bot bot merged commit 6f0737a into containers:main May 28, 2024
89 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 27, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman console output inconsistent use of id / name
3 participants