-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have pod.Name display instead of pod.ID on start and stop reports #22806
Have pod.Name display instead of pod.ID on start and stop reports #22806
Conversation
f0eac62
to
a7245da
Compare
Signed-off-by: jkwiatko <[email protected]>
998e5f6
to
b453642
Compare
test/upgrade/test-upgrade.bats
Outdated
@@ -10,88 +10,88 @@ load helpers | |||
# options both in the container podman and out here: that's the only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yikes, most of this file seems to have been modified by my IDE, I'll check to see that i can disable that on save to simplify the changes.
Thanks @JayKayy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, code LGTM but please revert the changes to test/upgrade/test-upgrade.bats
Signed-off-by: jkwiatko <[email protected]>
@giuseppe reverted auto-format changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, JayKayy, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@giuseppe The failure in CI looks like it may be a flake. I don't believe my changes would affect WSL or |
I just reran it. |
Does this PR introduce a user-facing change?
This change brings the
podman pod start
andpodman pod stop
output to be more consistent with the output ofpodman start
andpodman stop
. Starting and stopping pods now print the pod name instead of thepod.ID()
Closes #22590
How to test
Before:
After: