Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to cobra CLI #2274

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Migrate to cobra CLI #2274

merged 1 commit into from
Feb 8, 2019

Conversation

baude
Copy link
Member

@baude baude commented Feb 5, 2019

We intend to migrate to the cobra cli from urfave/cli because the
project is more well maintained. There are also some technical reasons
as well which extend into our remote client work.

Signed-off-by: baude [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2019
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 5, 2019
@baude
Copy link
Member Author

baude commented Feb 5, 2019

This PR is not ready for review yet. I'm first trying to see if we can pas integration testing with what we have. Next I will need to conduct a majorly painful rebase.

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #2259) made this pull request unmergeable. Please resolve the merge conflicts.

@baude baude force-pushed the cobraprep branch 7 times, most recently from 701757b to 4aeac4e Compare February 6, 2019 21:57
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #2252) made this pull request unmergeable. Please resolve the merge conflicts.

@baude baude changed the title [WIP] Migrate to cobra CLI Migrate to cobra CLI Feb 7, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2019
@baude
Copy link
Member Author

baude commented Feb 7, 2019

This is ready for review while I try to convince make vendor and the integrations tests that we are cool

@giuseppe
Copy link
Member

giuseppe commented Feb 7, 2019

tested with rootless containers, and it seems to work

@vrothberg
Copy link
Member

Great work, @baude! make vendor seems happy now 👍

rhatdan
rhatdan reviewed Feb 7, 2019
View reviewed changes
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good job @baude.
A ton of nits, but overall looks great.

cmd/podman/attach.go Outdated Show resolved Hide resolved
cmd/podman/build.go Outdated Show resolved Hide resolved
cmd/podman/commands.go Outdated Show resolved Hide resolved
cmd/podman/common.go Outdated Show resolved Hide resolved
cmd/podman/common.go Outdated Show resolved Hide resolved
cmd/podman/trust_set_show.go Outdated Show resolved Hide resolved
cmd/podman/utils.go Outdated Show resolved Hide resolved
cmd/podman/utils.go Outdated Show resolved Hide resolved
cmd/podman/wait.go Outdated Show resolved Hide resolved
cmd/podman/wait.go Outdated Show resolved Hide resolved
TomSweeneyRedHat
TomSweeneyRedHat reviewed Feb 7, 2019
View reviewed changes
.idea/libpod.iml Outdated Show resolved Hide resolved
mheon
mheon reviewed Feb 8, 2019
View reviewed changes
cmd/podman/attach.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Feb 8, 2019
View reviewed changes
cmd/podman/checkpoint.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Feb 8, 2019
View reviewed changes
cmd/podman/common.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Feb 8, 2019
View reviewed changes
cmd/podman/create.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Feb 8, 2019
View reviewed changes
cmd/podman/history.go Outdated Show resolved Hide resolved
@baude
Migrate to cobra CLI
25a3923 
We intend to migrate to the cobra cli from urfave/cli because the
project is more well maintained.  There are also some technical reasons
as well which extend into our remote client work.

Signed-off-by: baude <[email protected]>
@mheon
Copy link
Member

mheon commented Feb 8, 2019

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM too, I'm sure there'll be a few things that shake out from this, but I say ship this now and fix any malingering issues later.

Really, really nice job here @baude.

@mheon
Copy link
Member

mheon commented Feb 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019
@openshift-merge-robot openshift-merge-robot merged commit afd4d5f into containers:master Feb 8, 2019
This was referenced Feb 8, 2019
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Merged
@baude baude deleted the cobraprep branch December 22, 2019 18:46
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe left review comments

@rhatdan rhatdan rhatdan left review comments

@mheon mheon mheon left review comments

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@baude @openshift-ci-robot @rh-atomic-bot @giuseppe @vrothberg @mheon @TomSweeneyRedHat @rhatdan @openshift-merge-robot