Use built-in ssh impl for all non-pty operations #22150
Conversation
n1hility
added
the
No New Tests
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
n1hility
force-pushed
the
pref-builtin-ssh
branch
2 times, most recently
from
d7c3675 to
c3f5633
Compare
Windows is not guaranteed to have the SSH feature installed, so prefer the use of the built-in ssh client for all operations other than podman machine ssh, which requires terminal pty logic. This restores previous behavior in 4.x. Signed-off-by: Jason T. Greene <[email protected]>
n1hility
force-pushed
the
pref-builtin-ssh
branch
from
c3f5633 to
11415b3
Compare
|
/cherry-pick v5.0 |
|
@n1hility: once the present PR merges, I will cherry-pick it on top of v5.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PTAL @baude @mheon @Luap99 @ashley-cui Not urgent but want to make sure its considered for 5.0.1 |
|
LGTM and thanks! |
|
/lgtm |
|
@n1hility: new pull request created: #22162 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
stale-locking-app
bot
added
the
locked - please file new issue/PR
Fixes #22075
Windows is not guaranteed to have the SSH feature installed, so prefer the use of the built-in ssh client for all operations other than podman machine ssh, which requires terminal pty logic. This restores previous behavior in 4.x.
Note this does not reuse the pkg/common binding client code since the usage patterns do not fully map, and would result in roughly the same amount of code.