Mask unimplemeted commands for remote client #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Cool to see how fast the remote client is progressing 👀 |
|
Sure, LGTM |
|
bot, retest this please |
|
@mheon you were the second lgtm, mind pulling the trigger? |
|
@baude, you've some unhappy tests, not sure if that's expected today. |
|
LGTM assuming happy tests |
baude
force-pushed
the
remotemaskcommands
branch
from
222ed46 to
4e4041e
Compare
rhatdan
reviewed
Jan 18, 2019
baude
force-pushed
the
remotemaskcommands
branch
from
4e4041e to
2767ee8
Compare
baude
force-pushed
the
remotemaskcommands
branch
from
2767ee8 to
64643ed
Compare
rhatdan
reviewed
Jan 18, 2019
baude
force-pushed
the
remotemaskcommands
branch
from
64643ed to
af0f703
Compare
|
@rhatdan should be updated with sorts now |
Masking main level, image, and container commands that are not yet implemented for the remote client. As each command is completed, be sure to unmask it. Also, masking podman command line switches that are not applicable to the remote client. Signed-off-by: baude <[email protected]>
baude
force-pushed
the
remotemaskcommands
branch
from
af0f703 to
6f6cf86
Compare
|
/lgtm |
This was referenced Jan 20, 2019
Merged
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Masking main level, image, and container commands that are not yet
implemented for the remote client. As each command is completed, be
sure to unmask it.
Also, masking podman command line switches that are not applicable
to the remote client.
Signed-off-by: baude [email protected]