Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cross platform support in QEMU machine sources #21686

Merged

Conversation

arixmkii
Copy link
Contributor

Bugfixes extracted from a bigger change #21594

This change:

  • cleanups some old Windows bits used in machine 4 times;
  • converts socket path into cross platform compatible in gvproxy command
  • fixes typo in log
  • resolves QEMU settings from machine config QEMUHypervisor part instead of QEMUStubber. In my testing it was always resulting in {nil} QMP socket and incorrect machine termination on Windows. I haven't yet checked it on Linux.

Does this PR introduce a user-facing change?

None

[NO NEW TESTS NEEDED]

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@arixmkii
Copy link
Contributor Author

I also checked stubbers for all other providers. If one completely removes vmconfig from there everything seems to compile. It looks like this vmconfig part of Stubber is a sort of work in progress, which was only referenced in QEMU machine, where the real machine config is also available. This part is really weird.

@rhatdan
Copy link
Member

rhatdan commented Feb 16, 2024

Thanks @arixmkii
LGTM
@ashley-cui @baude @jakecorrenti PTAL

@baude
Copy link
Member

baude commented Feb 18, 2024

good catch

LGTM

/approve

Copy link
Contributor

openshift-ci bot commented Feb 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arixmkii, baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2024
@rhatdan
Copy link
Member

rhatdan commented Feb 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 630bfbf into containers:main Feb 18, 2024
89 of 91 checks passed
@arixmkii arixmkii deleted the qemu-machine-5-bugfixes branch March 1, 2024 13:58
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 31, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants