Re-enable testing #21551
Merged
Re-enable testing #21551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
baude
force-pushed
the
turnmacbackon
branch
2 times, most recently
from
82bebe6 to
aea5434
Compare
Merged
|
@baude if artifacts task breaks, I'm okay w/ leaving it disabled for now. It's really not important (IMHO) until the very very end of all the "un-commenting" activities. |
cevich
reviewed
Feb 8, 2024
cevich
reviewed
Feb 8, 2024
openshift-merge-robot
added
the
needs-rebase
we were fighting a flake earlier, so the mac test was removed again and the suspected commit was removed. this turns the test back on so we can see if we pass cleanly. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-merge-robot
removed
the
needs-rebase
Co-authored-by: Chris Evich <[email protected]> Signed-off-by: Brent Baude <[email protected]>
|
ready for merge, lets get this in. |
cevich
added a commit
to cevich/podman
that referenced
this pull request
Feb 12, 2024
Followup to containers#21551 Note: Fixed indentation of podman-machine mac task. Signed-off-by: Chris Evich <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, cevich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
cevich
added a commit
to cevich/podman
that referenced
this pull request
Feb 13, 2024
**Depends on:** - containers#21551 - containers#21562 Signed-off-by: Chris Evich <[email protected]>
cevich
added a commit
to cevich/podman
that referenced
this pull request
Feb 13, 2024
**Depends on:** - containers#21551 - containers#21562 - containers#21564 Signed-off-by: Chris Evich <[email protected]>
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were fighting a flake earlier, so the mac test was removed again and the suspected commit was removed. this turns the test back on so we can see if we pass cleanly. Also lets turn on as much windows as possible and hyperv.
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?