Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up: remove unused file #21292

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

yyzxw
Copy link
Contributor

@yyzxw yyzxw commented Jan 18, 2024

Does this PR introduce a user-facing change?

clean up useless files, it duplicates with https://github.com/containers/podman/blob/main/cmd/podman/diff/diff.go

[NO NEW TESTS NEEDED]

@giuseppe
Copy link
Member

please add [NO NEW TESTS NEEDED] to the commit message

@rhatdan
Copy link
Member

rhatdan commented Jan 18, 2024

Thanks @yyzxw
Please repush your commit, I added [NO NEW TESTS NEEDED]

@mheon
Copy link
Member

mheon commented Jan 18, 2024

LGTM once re-pushed with no tests needed message.

@mheon
Copy link
Member

mheon commented Jan 18, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@TomSweeneyRedHat
Copy link
Member

LGTM
once the tests are hip

@yyzxw
Copy link
Contributor Author

yyzxw commented Jan 22, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

@yyzxw: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented Jan 22, 2024

You need to repush to trigger CI to see [NO NEW TESTS NEEDED] flag.

git commit -a --amend -s
git push --force

@yyzxw yyzxw force-pushed the chore/remove-unused-file branch from e3e276e to f53cb9c Compare January 23, 2024 01:41
@yyzxw
Copy link
Contributor Author

yyzxw commented Jan 29, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

@yyzxw: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mheon
Copy link
Member

mheon commented Jan 29, 2024

Last test remaining is an allowed failure, this is good.

@mheon
Copy link
Member

mheon commented Jan 29, 2024

/lgtm
/approve

Thanks @yyzxw

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, yyzxw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2ba3605 into containers:main Jan 29, 2024
91 of 92 checks passed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants