-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix push endpoint stream #21004
Fix push endpoint stream #21004
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am not sure if there is a way to add tests for this, it does look like there is a test for this here https://github.com/containers/podman/blob/main/test/apiv2/12-imagesMore.at#L36 but it doesn't work as expected? @edsantiago any idea if there is a good way to test this? |
Looks like the test is calling the compat endpoint and not the libpod one, so you need to add another which calls |
f419e52
to
112563f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes itself LGTM, just two comments for the test
Even with slashes removed, tests fail. @umohnani8 you can run tests locally with: $ ./test/apiv2/test-apiv2 12 |
The push binding endpoint wasn't actually writing the output data to the stream when quiet=false and there was no push error. Do not hard code quiet=true anymore, take into account the user input. Signed-off-by: Urvashi Mohnani <[email protected]>
112563f
to
126670d
Compare
Thanks @edsantiago, tests should be happy now! |
LGTM |
/lgtm |
b82e336
into
containers:main
The push binding endpoint wasn't actually writing the output data to the stream when quiet=false and there was no push error.
Do not hard code quiet=true anymore, take into account the user input.
Does this PR introduce a user-facing change?