Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] fix broken labeler.yml config #20924

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Dec 6, 2023

Commit ca66a90 was merged without fixing the config. Please read changelogs before merging renovate PRs, especially when it is a major version bump.

Does this PR introduce a user-facing change?

None

Commit ca66a90 was merged without fixing the config. Please read
changelogs before merging renovate PRs, especially when it is a major
version bump.

Signed-off-by: Paul Holzinger <[email protected]>
Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
@rhatdan
Copy link
Member

rhatdan commented Dec 6, 2023

Tests are blowing up?

@edsantiago
Copy link
Member

Labeler is expected to blow up, because there's a broken commit on main.

LGTM, but to be fair the project release notes are evil. The CORRECT way to do release notes is to give recipes: "if you do this, change it to that". Their release notes show the new format, but give no clue to poor end users.

@Luap99
Copy link
Member Author

Luap99 commented Dec 6, 2023

This is the same errors as on other PRs, AFAIK github actions only run based of main thus you only see the fixes after merge and that is why it worked on the renovate PR. So yes this will fail until this is merged, I took the syntax from the examples so I assume it is correct.

@edsantiago
Copy link
Member

/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Dec 6, 2023
@Luap99
Copy link
Member Author

Luap99 commented Dec 6, 2023

Why do we run machine-mac podman darwin rootless host sqlite with CI:DOCS? cc @cevich

@edsantiago
Copy link
Member

Maybe a copy-paste error from osx alt build?? It has the "no_rhel_release" conditional; everything else has the usual set of skips:
cirrus-map-main-cropped

@cevich
Copy link
Member

cevich commented Dec 6, 2023

It has the "no_rhel_release" conditional

That was on purpose, but maybe the conditional is broken WRT [CI:DOCS]? We definitely don't want the machine tests running on anything but main (since there's no mac/windows artifact that needs tracking on a release branch).

@cevich
Copy link
Member

cevich commented Dec 6, 2023

Ahh, yep, just looked at the yaml. This is a copy-paste typo. It should match the podman_machine_windows_task conditions (which don't run for [CI:DOCS]). My bad.

@Luap99
Copy link
Member Author

Luap99 commented Dec 6, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 605a29a into containers:main Dec 6, 2023
38 of 41 checks passed
@Luap99 Luap99 deleted the labeler branch December 6, 2023 18:39
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Mar 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants