-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] fix broken labeler.yml config #20924
Conversation
Commit ca66a90 was merged without fixing the config. Please read changelogs before merging renovate PRs, especially when it is a major version bump. Signed-off-by: Paul Holzinger <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tests are blowing up? |
Labeler is expected to blow up, because there's a broken commit on LGTM, but to be fair the project release notes are evil. The CORRECT way to do release notes is to give recipes: "if you do this, change it to that". Their release notes show the new format, but give no clue to poor end users. |
This is the same errors as on other PRs, AFAIK github actions only run based of main thus you only see the fixes after merge and that is why it worked on the renovate PR. So yes this will fail until this is merged, I took the syntax from the examples so I assume it is correct. |
/lgtm |
Why do we run |
That was on purpose, but maybe the conditional is broken WRT |
Ahh, yep, just looked at the yaml. This is a copy-paste typo. It should match the |
/hold cancel |
605a29a
into
containers:main
Commit ca66a90 was merged without fixing the config. Please read changelogs before merging renovate PRs, especially when it is a major version bump.
Does this PR introduce a user-facing change?