-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quadlet: Support healthy
for Notify
directives
#20714
quadlet: Support healthy
for Notify
directives
#20714
Conversation
The golinter doesn't like the way you've implemented the three cases. |
Hmmm it seems to want this to be a |
LGTM with the linter-suggested switch-case conversion |
This expands support for the (previously) boolean `Notify` directive, in support of healthcheck determined SD-NOTIFY event emission, as supported by Podman with the `--sdnotify=healthy` option. Closes: containers#18189 Signed-off-by: Alex Palaistras <[email protected]>
41e31e7
to
6cb2f9b
Compare
Hmmm, strange error out of
Not sure if this is a flaky test, or perhaps something unexpected changed here? |
Since the same test ran successfully on the other platforms, I assume it's a flake. But, @edsantiago can you PTAL? |
Flake is #10927, one of our oldest and most annoying flakes. I've restarted the failed job. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deuill, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks so much for fixing tests and for the quick turnaround here! |
This expands support for the (previously) boolean
Notify
directive, in support of healthcheck determined SD-NOTIFY event emission, as supported by Podman with the--sdnotify=healthy
option.Fixes: #18189