Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quadlet: Support healthy for Notify directives #20714

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

deuill
Copy link
Contributor

@deuill deuill commented Nov 18, 2023

This expands support for the (previously) boolean Notify directive, in support of healthcheck determined SD-NOTIFY event emission, as supported by Podman with the --sdnotify=healthy option.

Fixes: #18189

Support `healthy` for `Notify` directives in Quadlet

@ygalblum
Copy link
Contributor

The golinter doesn't like the way you've implemented the three cases.

@deuill
Copy link
Contributor Author

deuill commented Nov 19, 2023

The golinter doesn't like the way you've implemented the three cases.

Hmmm it seems to want this to be a switch, oh well. I was hoping to have CI pass on first go, but alas, I'll run tests locally before pushing again!

@mheon
Copy link
Member

mheon commented Nov 20, 2023

LGTM with the linter-suggested switch-case conversion

This expands support for the (previously) boolean `Notify` directive, in
support of healthcheck determined SD-NOTIFY event emission, as
supported by Podman with the `--sdnotify=healthy` option.

Closes: containers#18189
Signed-off-by: Alex Palaistras <[email protected]>
@deuill deuill force-pushed the quadlet-notify-healthy branch from 41e31e7 to 6cb2f9b Compare November 21, 2023 18:09
@deuill
Copy link
Contributor Author

deuill commented Nov 21, 2023

Hmmm, strange error out of localsystem tests:

[+0742s] # [12:55:03.052781581] # /var/tmp/go/src/github.com/containers/podman/bin/podman exec -t test sh -c echo -n $TERM
[+0742s] # /usr/lib/bats-core/test_functions.bash: line 383: warning: command substitution: ignored null byte in input
[+0742s] # [12:55:03.188913483] Error: container create failed (no logs from conmon): conmon bytes "": readObjectStart: expect { or n, but found , error found in #0 byte of ...||..., bigger context ...||...
[+0742s] # [12:55:03.197253125] [ rc=255 (** EXPECTED 0 **) ]
[+0742s] # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
[+0742s] # #| FAIL: exit code is 255; expected 0
[+0742s] # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[+0742s] # # [teardown]

Not sure if this is a flaky test, or perhaps something unexpected changed here?

@ygalblum
Copy link
Contributor

Since the same test ran successfully on the other platforms, I assume it's a flake. But, @edsantiago can you PTAL?

@edsantiago
Copy link
Member

Flake is #10927, one of our oldest and most annoying flakes. I've restarted the failed job.

@rhatdan
Copy link
Member

rhatdan commented Nov 22, 2023

/approve
/lgtm
Thanks @deuill

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deuill, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 2f160f8 into containers:main Nov 22, 2023
93 checks passed
@deuill
Copy link
Contributor Author

deuill commented Nov 22, 2023

Thanks so much for fixing tests and for the quick turnaround here!

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quadlet support depending on health conditions for container
5 participants