qemu,parseUSB: minor refactor #20678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@victortoso PTAL |
flouthoc
force-pushed
the
usb_pass_cleanup
branch
from
16ed237 to
4793e2c
Compare
|
/lgtm as well |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
@flouthoc please rebase on main to fix CI |
Some comments from containers#20540 [NO NEW TESTS NEEDED] Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
usb_pass_cleanup
branch
from
4793e2c to
33ddd79
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
/lgtm |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit 9c95473
into
containers:main
91 of 92 checks passed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments from #20540
Does this PR introduce a user-facing change?