-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.7] fix: check wsl npipe when executing podman compose #20491
Conversation
[NO NEW TESTS NEEDED] Signed-off-by: lstocchi <[email protected]> Cherry-picked-by: Valentin Rothberg <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@cevich CI on this branch is sick |
@baude shall we merge and get CI back later? |
Just adding the upstream PR for reference: #20478 |
The only reason I can think of to run it across multiple platforms is to ensure it also functions if a developer runs it locally (on their random platform). Maybe we don't care. I'm fine if someone wants to strip out the aarch64 validate. |
I think that the test definitely has value so long as we build for Macs, and we aren't planning on dropping that any time soon. Any idea what's going on - is it just this branch? |
@Luap99 I think the multiple validates is mostly about build tags - we have a lot of things (esp. in machine) build-tagged for a single architecture or OS |
Can we get this in? |
Aaaahhh, that sounds like a good reason. Otherwise those files would all just be ignored. In any case, the python failure here I'm clueless about. The pre-commit (python) check has no use across multiple arches (that I'm aware of). Unfortunately this is an item that does runtime installs as well, so...well...there you go. It's been a long while since I looked at these CI codepaths, but IIRC they're all lumped in together under a single make target :S |
Alright, I'm just going to press the button. I would say we should investigate further, but we only have to maintain this branch for another ~3 weeks, so it's probably not worth it. |
Oh forget it, definitely not worth it. And we don't see this happening on |
Does this PR introduce a user-facing change?