Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Fix specification of unix:///run #20005

Merged
merged 1 commit into from
Sep 18, 2023
Merged

[CI:DOCS] Fix specification of unix:///run #20005

merged 1 commit into from
Sep 18, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 17, 2023

Does this PR introduce a user-facing change?

None

@rhatdan
Fix specification of unix:///run
03dd5f2 
Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2023
@rhatdan rhatdan added the 4.7 label Sep 17, 2023
@afbjorklund afbjorklund mentioned this pull request Sep 17, 2023
Merged
vrothberg
vrothberg approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member Author

rhatdan commented Sep 18, 2023

@afbjorklund @TomSweeneyRedHat @Luap99 @giuseppe @mheon PTAL

@afbjorklund
Copy link
Contributor

Looks good to me.

It is still OK to use unix:/run/... URL, but unfortunately that syntax does not work with the docker client*.

* it tries to use tcp, and fails:

error during connect: Get "http://unix:2375/run/podman/podman.sock/v1.24/version": dial tcp: lookup unix: no such host

Using unix://run/... made into a relative path, so you needed to do cd / before the connection would work.

Thus, unix:///

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Luap99
Luap99 reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit 364f989 into containers:main Sep 18, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@vrothberg vrothberg vrothberg approved these changes

@afbjorklund afbjorklund afbjorklund approved these changes

Assignees

@Luap99 Luap99

Labels
4.7 approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhatdan @afbjorklund @vrothberg @Luap99 @openshift-merge-robot