-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor of containers/(common, storage, image) #19929
Conversation
Signed-off-by: Daniel J Walsh <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Preparing for release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but before the RC is cut we probably need released versions of common, storage, image.
Not before RC, but before final. |
I think in our release process doc we said that RC's were intended to be fully stable and ready for release, which means we probably want a versioned common, storage, image. In any case, we can do another dance on the branch when it's cut. |
Sure, the problem with that is it does not allow for bug fixes in any level without requiring a complete vendor dance. I have no problem doing it, but I don't believe we have dones this in the past. |
We really need to go over the release doc again and finalize it to have a solid answer here, but the goal was to make RCs more stable - IIRC, so we would be comfortable if one somehow ended up in Fedora Stable. |
That being said, I have no objections about merging this now and figuring out details later, we have a few days. |
Adding bloat label
|
I think the bloat is all in the Windows code paths. But does that affect the size of the linux app or the Mac Client? |
Does this PR introduce a user-facing change?