Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor of containers/(common, storage, image) #19929

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 11, 2023

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Sep 11, 2023
@rhatdan
Copy link
Member Author

rhatdan commented Sep 11, 2023

Preparing for release.

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but before the RC is cut we probably need released versions of common, storage, image.

@rhatdan
Copy link
Member Author

rhatdan commented Sep 11, 2023

Not before RC, but before final.

@ashley-cui
Copy link
Member

I think in our release process doc we said that RC's were intended to be fully stable and ready for release, which means we probably want a versioned common, storage, image. In any case, we can do another dance on the branch when it's cut.

@rhatdan
Copy link
Member Author

rhatdan commented Sep 11, 2023

Sure, the problem with that is it does not allow for bug fixes in any level without requiring a complete vendor dance. I have no problem doing it, but I don't believe we have dones this in the past.

@mheon
Copy link
Member

mheon commented Sep 11, 2023

We really need to go over the release doc again and finalize it to have a solid answer here, but the goal was to make RCs more stable - IIRC, so we would be comfortable if one somehow ended up in Fedora Stable.

@mheon
Copy link
Member

mheon commented Sep 11, 2023

That being said, I have no objections about merging this now and figuring out details later, we have a few days.

@mheon
Copy link
Member

mheon commented Sep 11, 2023

Adding bloat label


* bin/podman grew by 65544 bytes; max allowed is 51200.
*
* Please investigate, and fix if possible.
*
* A repo admin can override by setting the bloat_approved label

@mheon mheon added the bloat_approved Approve a PR in which binary file size grows by over 50k label Sep 11, 2023
@rhatdan
Copy link
Member Author

rhatdan commented Sep 12, 2023

I think the bloat is all in the Windows code paths. But does that affect the size of the linux app or the Mac Client?

@rhatdan rhatdan added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit e967350 into containers:main Sep 12, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants