[v4.3] system reset: show graphRoot/runRoot before removal #19875
Conversation
Backport of commit 6aaf6a2. system reset it says it will delete containers, images, networks, etc... However it will also delete the graphRoot and runRoot directories. Normally this is not an issue, however in same cases these directories were set to the users home directory or some other important system directory. As first step simply show the directories that are configured and thus will be deleted by reset. As future step we could implement some safeguard will will not delete some known important directories however I tried to keep it simple for now. [NO NEW TESTS NEEDED] see containers#18349 and containers#18295 Signed-off-by: Paul Holzinger <[email protected]> Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
https://github.com/orgs/containers/teams/podman-maintainers PTAL @siretart feel free to grab this PR for Debian/Ubuntu |
|
LGTM |
|
Failures are expected as this branch is practically dead. @cevich FYI |
|
I would describe it as more than practically dead. It's no longer in use at all per my understanding, we should not be running any CI jobs automatically on it. |
|
LGTM regardless. I'll leave it up to you whether you want to try and fix CI (probably best to just turn everything except the basics off?) or push the merge button. |
|
I am merging as is. Compiled and tested locally. |
|
Thanks for letting me know. Turns out, I've already had integrated this into Debian a couple of months ago in https://salsa.debian.org/debian/libpod/-/commit/e893ca805993edfb17ebb318e2bdc54de03af487. Please do keep cc'ing me on important backports like this to ensure we don't miss out! |
github-actions
bot
added
the
locked - please file new issue/PR
Backport of commit 6aaf6a2.
system reset it says it will delete containers, images, networks, etc... However it will also delete the graphRoot and runRoot directories. Normally this is not an issue, however in same cases these directories were set to the users home directory or some other important system directory.
As first step simply show the directories that are configured and thus will be deleted by reset. As future step we could implement some safeguard will will not delete some known important directories however I tried to keep it simple for now.
[NO NEW TESTS NEEDED]
see #18349 and #18295
Does this PR introduce a user-facing change?