Small fixes for hyperv #19794
Merged
Small fixes for hyperv #19794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
the remote username was being set too "late" for hyperv and the username for ssh connections was blank. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
in gvisor-vsock-tap upstream, there is a binary called 'vm' which is used for routing traffic from a tap over something like vsock. In Fedora, the binary is named 'gvforwarder'. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
|
LGTM |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
Upgrade-test failures are expected since the images were nuked from Quay.io. I am not sure what to do. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?