Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:BUILD] Packit: Adjustments for Cockpit reverse-dependency check #19753

Merged
merged 2 commits into from
Aug 25, 2023
Merged

[CI:BUILD] Packit: Adjustments for Cockpit reverse-dependency check #19753

merged 2 commits into from
Aug 25, 2023

Conversation

martinpitt
Copy link
Contributor

Please see the two individual commit messages for details. This will robustify the test against unrelated non-fatal unexpected message checks, seen in #19741.

Does this PR introduce a user-facing change?

None

@martinpitt
[CI:BUILD] Packit: Restrict cockpit tests to recent Fedoras
a6f2f58 
The cockpit team only ever supports two parallel Fedora releases, and
will soon discontinue updating Fedora 37. So, instead of risking testing
against an obsolete Fedora, test against the most recent stable and
all development series. These are often fewer than we support, but
that's totally sufficient for this purpose.

[NO NEW TESTS NEEDED] - This is test configuration.

Signed-off-by: Martin Pitt <[email protected]>
@martinpitt
[CI:BUILD] Packit: Disable unexpected journal message check for cockp…
b8146a8 
…it-podman

These are relevant when validating upstream or selinux-policy changes,
but not podman ones. This makes the revdeps tests more robust against
random (non-fatal) SELinux denials or messages from other system
components.

[NO NEW TESTS NEEDED] - This is test configuration.

Signed-off-by: Martin Pitt <[email protected]>
@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 25, 2023
@martinpitt
Copy link
Contributor Author

martinpitt commented Aug 25, 2023 •
edited
Loading

Awesome, someone broke c8s+epel-next-8:

 Problem 1: cannot install the best candidate for the job
  - nothing provides glibc-devel = 2.28-234.el8 needed by glibc-static-2.28-234.el8.x86_64 from powertools
 Problem 2: cannot install the best candidate for the job
  - nothing provides shadow-utils-subid = 2:4.6-19.el8 needed by shadow-utils-subid-devel-2:4.6-19.el8.x86_64 from powertools

Unrelated, and I can't retry tests here anyway, so I'll leave it at that.

@lsm5 do you mind reviewing? Thanks!

@martinpitt martinpitt marked this pull request as ready for review August 25, 2023 16:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2023
@lsm5
Copy link
Member

lsm5 commented Aug 25, 2023

i've notified copr folks about it already. We can ignore those for now.

@lsm5 lsm5 self-assigned this Aug 25, 2023
@lsm5
Copy link
Member

lsm5 commented Aug 25, 2023

@martinpitt will review in a bit, thanks

@lsm5
Copy link
Member

lsm5 commented Aug 25, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, martinpitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@lsm5
Copy link
Member

lsm5 commented Aug 25, 2023

@martinpitt did you mean you didn't have permission to run slash-packit commands here?

@openshift-merge-robot openshift-merge-robot merged commit f521fd2 into containers:main Aug 25, 2023
@lsm5
Copy link
Member

lsm5 commented Aug 25, 2023

/cherry-pick v4.6

@openshift-cherrypick-robot
Copy link
Collaborator

@lsm5: new pull request created: #19756

In response to this:

/cherry-pick v4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 25, 2023
Merged
@martinpitt martinpitt deleted the revdeps-adjustments branch August 26, 2023 04:30
@martinpitt
Copy link
Contributor Author

@lsm5 ah, slash-packit may have worked, but I am not allowed to do the Re-run action in the packit status view

@lsm5
Copy link
Member

lsm5 commented Aug 29, 2023

@lsm5 ah, slash-packit may have worked, but I am not allowed to do the Re-run action in the packit status view

@martinpitt ack. don't know if you need to be in the OWNERS file for it, or if this is a thing packit could solve on their side. I'll ask around.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@lsm5 lsm5

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinpitt @lsm5 @openshift-cherrypick-robot @openshift-merge-robot