use container restart policy if user specifies one

[rhatdan]

Fixes: #19671

Does this PR introduce a user-facing change?

If restart policy is specified for container in a pod, then use it rather then the pods restart policy.

[flouthoc]

I think this should be other way around, all containers must inherit pod policy only and default pod-policy should be Always. See:https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-policy

[vrothberg]

Changes LGTM

Another reminder to write commit messages.

[vrothberg]

I think this should be other way around, all containers must inherit pod policy only and default pod-policy should be Always. See:https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-policy

That's not how it was designed. We wanted a container to always by able to override the restart policy if explicitly set by the user and otherwise inherit the pod's default.

Note that this is podman pod ... not podman kube ....

[rhatdan]

Yes in Kubernetes world, I don't think a container can specify a restart policy in the kube.yaml. In Pod's though they can so we should honor the more specific setting.

@flouthoc ^^

@containers/podman-maintainers PTAL

[flouthoc]

LGTM , I confused between podman kube and podman pod
/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [flouthoc,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrothberg]

/cherry-pick v4.6

[openshift-cherrypick-robot]

@vrothberg: new pull request created: #19682

In response to this:

/cherry-pick v4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[TomSweeneyRedHat]

@vrothberg Please cherry-pick to Podman v4.6.1-rhel ASAP. Two BZ's spun your way to allow for that. https://bugzilla.redhat.com/show_bug.cgi?id=2233222 and https://bugzilla.redhat.com/show_bug.cgi?id=2233218

[mheon]

/cherry-pick v4.6.1-rhel

[openshift-cherrypick-robot]

@mheon: new pull request created: #19692

In response to this:

/cherry-pick v4.6.1-rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.