Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:BUILD] rpm: depend on man-db #19670

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Aug 17, 2023

Include dependencies in rpm/podman.spec to make it easy for end users to build podman from source. This way users can install all build dependencies by running dnf -y builddep rpm/podman.spec.

This is not usually noticeable except on container environments where man-db often isn't installed by default.

Refs:
containers/podman.io#157
containers/podman.io#174

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

Include dependencies in rpm/podman.spec to make it easy for end users to
build podman from source. This way users can install all build
dependencies by running `dnf -y builddep rpm/podman.spec`.

This is not usually noticeable except on container environments where
man-db often isn't installed by default.

Refs:
containers/podman.io#157
containers/podman.io#174

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 17, 2023
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flouthoc
Copy link
Collaborator

@lsm5 rpm-build:centos-stream+epel-next-9-x86_64 is failing.

@rhatdan
Copy link
Member

rhatdan commented Aug 21, 2023

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, lsm5, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [flouthoc,lsm5,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member Author

lsm5 commented Aug 21, 2023

@lsm5 rpm-build:centos-stream+epel-next-9-x86_64 is failing.

@flouthoc ack. seems to be a quay flake and I'm surprised these were pulling from quay. Other builds have passed and the failure is unrelated to the change, so I'll ignore it. Might have a problem on our hands if quay keeps flaking. I can check with the copr infra people if that can be changed.

/hold cancel.

@lsm5
Copy link
Member Author

lsm5 commented Aug 21, 2023

/cherry-pick v4.6
/cherry-pick v4.6.1-rhel

@openshift-cherrypick-robot
Copy link
Collaborator

@lsm5: once the present PR merges, I will cherry-pick it on top of v4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick v4.6
/cherry-pick v4.6.1-rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lsm5
Copy link
Member Author

lsm5 commented Aug 21, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit 30ec94f into containers:main Aug 21, 2023
@openshift-cherrypick-robot
Copy link
Collaborator

@lsm5: new pull request created: #19685

In response to this:

/cherry-pick v4.6
/cherry-pick v4.6.1-rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@lsm5: new pull request created: #19686

In response to this:

/cherry-pick v4.6
/cherry-pick v4.6.1-rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
@lsm5 lsm5 deleted the rpm-dep-man branch October 25, 2024 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants