-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:BUILD] rpm: depend on man-db #19670
Conversation
Include dependencies in rpm/podman.spec to make it easy for end users to build podman from source. This way users can install all build dependencies by running `dnf -y builddep rpm/podman.spec`. This is not usually noticeable except on container environments where man-db often isn't installed by default. Refs: containers/podman.io#157 containers/podman.io#174 [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lsm5 rpm-build:centos-stream+epel-next-9-x86_64 is failing. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, lsm5, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@flouthoc ack. seems to be a quay flake and I'm surprised these were pulling from quay. Other builds have passed and the failure is unrelated to the change, so I'll ignore it. Might have a problem on our hands if quay keeps flaking. I can check with the copr infra people if that can be changed. /hold cancel. |
/cherry-pick v4.6 |
@lsm5: once the present PR merges, I will cherry-pick it on top of v4.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
@lsm5: new pull request created: #19685 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lsm5: new pull request created: #19686 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Include dependencies in rpm/podman.spec to make it easy for end users to build podman from source. This way users can install all build dependencies by running
dnf -y builddep rpm/podman.spec
.This is not usually noticeable except on container environments where man-db often isn't installed by default.
Refs:
containers/podman.io#157
containers/podman.io#174
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?