Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update machine init and set tests #19666

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

ashley-cui
Copy link
Member

@ashley-cui ashley-cui commented Aug 17, 2023

Podman machine inspect now shows if the machine is rootful

Init/Set with --rootful
Init/Set with --user-mode-networking

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 17, 2023
pkg/machine/e2e/init_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is missing context for reviewers.

docs/source/markdown/podman-machine-inspect.1.md Outdated Show resolved Hide resolved
pkg/machine/e2e/set_test.go Outdated Show resolved Hide resolved
pkg/machine/e2e/set_test.go Outdated Show resolved Hide resolved
cmd/podman/machine/init.go Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
Podman machine inspect now shows if the machine is rootful

Signed-off-by: Ashley Cui <[email protected]>
Init/Set with --rootful
Init/Set  with --user-mode-networking

Signed-off-by: Ashley Cui <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
@rhatdan
Copy link
Member

rhatdan commented Aug 26, 2023

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ashley-cui,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 92c5880 into containers:main Aug 28, 2023
@ashley-cui ashley-cui deleted the testinit branch September 28, 2023 22:03
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants