-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update machine init and set tests #19666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description is missing context for reviewers.
Podman machine inspect now shows if the machine is rootful Signed-off-by: Ashley Cui <[email protected]>
Init/Set with --rootful Init/Set with --user-mode-networking Signed-off-by: Ashley Cui <[email protected]>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Podman machine inspect now shows if the machine is rootful
Init/Set with --rootful
Init/Set with --user-mode-networking
Does this PR introduce a user-facing change?