Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.6] Skip tests that fail in gating #19636

Merged

Conversation

edsantiago
Copy link
Member

SELinux tests are failing in f37, f38, Rawhide. (Did I miss any?) Assume that the new container-selinux will never be available on any of those, so let's just skip those tests. #19376

Pasta ICMP test fails pretty consistently in Gating, and is even flaking in Cirrus, so let's skip that too. #19612

None

SELinux tests are failing in f37, f38, Rawhide. (Did I miss any?)
Assume that the new container-selinux will never be available on
any of those, so let's just skip those tests. containers#19376

Pasta ICMP test fails pretty consistently in Gating, and is even
flaking in Cirrus, so let's skip that too. containers#19612

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago changed the title Skip tests that fail in gating [v4.6] Skip tests that fail in gating Aug 15, 2023
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 15, 2023
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [edsantiago,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@openshift-merge-robot openshift-merge-robot merged commit 8183ba8 into containers:v4.6 Aug 16, 2023
@edsantiago edsantiago deleted the skip_flaky_gating_tests branch August 16, 2023 11:30
@edsantiago
Copy link
Member Author

@AdamWill this should help on the next podman build.

@AdamWill
Copy link

AdamWill commented Aug 16, 2023

Great, thanks! edit: and yeah, F39 branched now, so you missed one :D I would imagine the newer container-selinux has a shot at making at least Rawhide and F39, if you ask for it? Newer versions for stable releases (f37 and f38) are less likely though.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants