enabled hyperv image downloads #19596
Conversation
openshift-ci
bot
added
release-note-none
approved
| // acquireVMImage determines if the image is already in a FCOS stream. If so, | ||
| // retrieves the image path of the uncompressed file. Otherwise, the user has | ||
| // provided an alternative image, so we set the image path and download the image. | ||
| func (v HyperVVirtualization) acquireVMImage(opts machine.InitOptions) (*machine.VMFile, string, error) { |
There was a problem hiding this comment.
looks like this is copy paste from the qemu implementation, can we move this to a common function and share it between both backend to prevent duplication?
There was a problem hiding this comment.
we can and will but it needs to be part of a larger refactor. can we merge this and it will get done later.
There was a problem hiding this comment.
it will get done later.
I hear this all the time but only a few people actually take such commitment seriously
|
LGTM |
now that we have public hypverv fcos artifacts, we can download them instead of requiring a special build. Signed-off-by: Brent Baude <[email protected]> [NO NEW TESTS NEEDED]
container/common Config was recently updated to use FCOS default names, since Windows HyperV backend needs them, and these are common with other providers. Map this to values the WSL backend expects. [NO NEW TESTS NEEDED] Signed-off-by: Jason T. Greene <[email protected]>
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ready to merge, @Luap99 ? |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
As promised in containers#19596, this pr deduplicates and refactors image acquisition. All virt providers that use FCOS as its default now use the same code. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
now that we have public hypverv fcos artifacts, we can download them instead of requiring a special build.
Signed-off-by: Brent Baude [email protected]
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?