-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: e2e: reenable containerized checkpoint tests #19449
CI: e2e: reenable containerized checkpoint tests #19449
Conversation
And lo, a miracle occurred. Containerized checkpoint tests are no longer hanging. Reenable them. (Followup miracle: tests are still passing, after a year of not running!) Closes: containers#15015 Signed-off-by: Ed Santiago <[email protected]>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm confused about timings. These ran in 37:30 and 36:10 respectively, unlike my earlier attempt (see comments in #15015) where they took a lot longer. And another unrelated PR, #19419 which finished just now, ran 42:09 and 42:35. I can only conclude that there is great variation in containerized-testing run time. |
/hold cancel |
And lo, a miracle occurred. Containerized checkpoint tests are
no longer hanging. Reenable them.
(Followup miracle: tests are still passing, after a year of not
running!)
Closes: #15015
Signed-off-by: Ed Santiago [email protected]